Add support for asynchronous execution #91
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces asynchronous execution support.
Motivation
Sometimes, we'd like to run a command with a timeout, if the command stuck, user can be aware of it.
Proposal
fn run_timeout
.fn run_async
/fn read_async
and etc. to make use oftokio::time::timeout
. ✅ (which this PR choose)Change
run_async
,read_async
,read_stderr_async
, andoutput_async
methods to the Cmd struct under theasync
feature gating.tokio::time::timeout
to apply a timeout to asynchronous command execution.Relative issue
May move #76 forward?